Files imported via app.import are not included in production build

[MartinMalinda]

node: 7.5.0
os: darwin x64
ember-cli: 2.12.0-beta.1

Maybe but I'm missing something but imported files are only available in development build but not in production build.

  app.import('./bower_components/magnific-popup/dist/jquery.magnific-popup.min.js'); //not included in production build
  app.import('./vendor/plain.js'); //not included in production build

  app.import({
    production: './vendor/plain.js', //not included in production build
    development: './vendor/plain.js'
  });

Reproduction repo: https://github.com/MartinMalinda/ember-cli-import-issue

[Turbo87]

@MartinMalinda does that happen only on the 2.12 beta or in other releases too?

[rwjblue]

Does the same issue exist when you strip the leading ./ from the paths?

[MartinMalinda]

@rwjblue It works correctly without ./. It is strange that it works for dev though, It can lead to sneaky production bugs.
@Turbo87 It also does not load on 2.11, should I test on older releases as well?

I looked a few online code examples and official docs and none of them mention using ./. But still it is quite intuitive to put the ./ there as it's also supported syntax in module importing.

[stefanpenner]

@MartinMalinda thanks to checking, that def sounds like a bug then. Although a strange one...

[stefanpenner]

@rwjblue should we disallow relative paths? I am quite surprised they actually work, that isn't intended... but i can be convinced that we should support them.

[rwjblue]

@stefanpenner - I was also very surprised that relative paths worked here. IMO, relative paths "break" the mental model that we want folks to have which is that you are importing from some ephemeral tree that is reified just prior to final concatenation.

[rwjblue]

But I totally think its a bug that we somehow treat relative paths differently between ember b and ember b -prod.

[n1ru4l]

Edit: I was wrong :D Got it working, still struggling in understanding the ember-cli logic.

I can confirm this.

ember-cli: 2.14.0-beta.2
node: 7.9.0
os: darwin x64

I am importing a file with an absolute path in an addon. With ember build everything is okay. When using ember build -prod the file is not added to the bundle.

[pzac]

I'm getting the same issue with absolute paths. Is there any workaround?

[palamike]

I use "./" (relative path) and it work perfectly for both dev and prod.

[phantomphildius]

I had this same issue as well when upgrading to ember-cli 2.12.3, removing the relative path solved it though. Thanks!

[pzac]

We gave up and basically replaced App.import(foo) with import npm:foo

[Turbo87]

FWIW the import() method was only ever designed to work with paths starting with either vendor/ or bower_components/. Everything else shouldn't have worked and shouldn't be used. Note though that starting in Ember CLI 2.15 it will also allow and work with node_modules/ too.

[Turbo87]

I'm closing this issues as it seems to be working as intended

[pzac]

It would be nice if the documentation made this clear, this issue drove us crazy

[Turbo87]

@pzac pull requests welcome 😉