Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ESLint default config files in app/addon blueprints #6864

Closed
Turbo87 opened this issue Mar 16, 2017 · 4 comments
Closed

Include ESLint default config files in app/addon blueprints #6864

Turbo87 opened this issue Mar 16, 2017 · 4 comments

Comments

@Turbo87
Copy link
Member

Turbo87 commented Mar 16, 2017

Instead of running the ember-cli-eslint blueprint on ember new we should instead just duplicate the empty ESLint config files so that e.g. they show up at https://github.com/ember-cli/ember-new-output and also work with the --skip-npm flag.

@kellyselden
Copy link
Member

We discussed this before, but remind me. Why can't we just run the generator as part of the release process? It would show up in the npm dist, and we don't have to commit to master and maintain duplicates.

@Turbo87
Copy link
Member Author

Turbo87 commented Mar 16, 2017

the things that is most annoying for me personally is https://github.com/ember-cli/ember-cli/blob/master/RELEASE.md#test not working anymore with this setup

@Turbo87
Copy link
Member Author

Turbo87 commented Mar 16, 2017

tl;dr is that I think KISS might make sense here instead of making it infinitely complex just to save us from duplicating two files with 18 lines in total...

@rwjblue
Copy link
Member

rwjblue commented Mar 16, 2017

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants