Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git status dirty after running test suite #6909

Closed
clekstro opened this issue Mar 27, 2017 · 0 comments · Fixed by #6911
Closed

Git status dirty after running test suite #6909

clekstro opened this issue Mar 27, 2017 · 0 comments · Fixed by #6911
Labels
bug good first issue

Comments

@clekstro
Copy link
Contributor

On current master, an additional file file is present after running the test suite via npm run test-all: blueprints/addon/files/package.json.

After talking through this with @Turbo87, it's likely that this file is simply copied over from an app's package.json and not being cleaned up properly. I'll try to track this down and will submit a PR to fix if I find the offending test.
@clekstro clekstro mentioned this issue Mar 27, 2017
Merged
homu added a commit that referenced this issue Mar 28, 2017
@homu
Auto merge of #6911 - clekstro:fix-dirty-git-state, r=Turbo87
3cd7674 
Fix dirty git state

This fixes #6909. Inside of the `afterInstall` hook, we were using the async methods of fs-extra (`.remove()`) but not actually waiting for them to resolve. Instead, we use the sync variant to resolve the issue, as this ensures the file has been removed before we proceed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dirty git state clekstro/ember-cli
2 participants
@Turbo87 @clekstro