Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop grunt as our pseudo pipeline + build system #8

Closed
stefanpenner opened this issue Feb 2, 2014 · 4 comments
Closed

drop grunt as our pseudo pipeline + build system #8

stefanpenner opened this issue Feb 2, 2014 · 4 comments

Comments

@stefanpenner
Copy link
Contributor

No description provided.

@joefiorini
Copy link
Contributor

👍

@stefanpenner
Copy link
Contributor Author

@joliss + me have next weekend planned to drive this one forward

@fsmanuel
Copy link
Contributor

@stefanpenner after a discussion with @joliss about the use of broccoli I'm not sure if broccoli will replace grunt. or better to say that ember-cli has to fill in the gaps broccoli intentionally left.
How i get it is that ember-cli has to take some design and process decisions like

  • before a build ember-cli removes the old dist folder
  • a new build is located in the dist folder as a release (with a release number from package.json)
  • etc.

In that process broccoli does the asset-pipeline step very well.

Open questions next to the process would be the integration of testem as a test runner (in ember-cli that would be the --autotest option and maybe a separate ember test command).

Concerning #11 and the discussion about conditionals in index.html offers broccoli a different approach that i haven't fully understood right now. I'll briefly highlight key conditionals in the Broccolifile.js.

What i don't understand yet is how to include specific files from lets say moment.js like language files. They should be all in the (bower)tree i guess and probably in the build what makes me think of load overhead. Maybe @joliss can shed some light on it.

Should i start a new issue with some checkboxes to have a discussion and talk about things i missed?

@joefiorini joefiorini mentioned this issue Feb 21, 2014
Closed
@stefanpenner
Copy link
Contributor Author

so we are dropping grunt as the primary pipeline, as for the task runner we will bundle with, i am undecided.

grunt has been dropped as the build pipeline

homu added a commit that referenced this issue Aug 5, 2016
@homu
Auto merge of #6154 - ember-cli:greenkeeper-amd-name-resolver-0.0.6, …
d22998d 
…r=Turbo87

Update amd-name-resolver to version 0.0.6 🚀

Hello lovely humans,

[amd-name-resolver](https://www.npmjs.com/package/amd-name-resolver) just published its new version 0.0.6.

<table>
  <tr>
    <th align=left>
      State
    </th>
    <td>
      Update 🚀
    </td>
  </tr>
  <tr>
    <th align=left>
      Dependency
    </td>
    <td>
      amd-name-resolver
    </td>
  </tr>
  <tr>
    <th align=left>
      New version
    </td>
    <td>
      0.0.6
    </td>
  </tr>
  <tr>
    <th align=left>
      Type
    </td>
    <td>
      dependency
    </td>
  </tr>
</table>

This version is **not covered** by your **current version range**.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of amd-name-resolver.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and while I’m just a bot, there is a group of people who are happy to teach me new things. [Let them know](https://github.com/greenkeeperio/greenkeeper/issues/new).

Good luck with your project ✨

You rock!

🌴

---
The new version differs by 6 commits .

- [`4fa0909`](ember-cli/amd-name-resolver@4fa0909) <code>Release 0.0.6</code>
- [`0472294`](ember-cli/amd-name-resolver@0472294) <code>Merge pull request #8 from locks/patch-1</code>
- [`47a96cc`](ember-cli/amd-name-resolver@47a96cc) <code>Update package.json</code>
- [`38c0e14`](ember-cli/amd-name-resolver@38c0e14) <code>Merge pull request #7 from trentmwillis/repo-info</code>
- [`d642254`](ember-cli/amd-name-resolver@d642254) <code>Add repo info to package.json</code>
- [`84452f9`](ember-cli/amd-name-resolver@84452f9) <code>Adding travis</code>

See the [full diff](ember-cli/amd-name-resolver@65e926f...4fa0909).

---
This pull request was created by [greenkeeper.io](https://greenkeeper.io/).

<sub>Tired of seeing this sponsor message? ⚡ `greenkeeper upgrade`</sub>
homu added a commit that referenced this issue Aug 24, 2016
@homu
Auto merge of #6204 - ember-cli:greenkeeper-ember-cli-broccoli-0.17.2…
718c25a 
…, r=nathanhammond

Update ember-cli-broccoli to version 0.17.2 🚀

Hello lovely humans,

[ember-cli-broccoli](https://www.npmjs.com/package/ember-cli-broccoli) just published its new version 0.17.2.

<table>
  <tr>
    <th align=left>
      State
    </th>
    <td>
      Update 🚀
    </td>
  </tr>
  <tr>
    <th align=left>
      Dependency
    </td>
    <td>
      ember-cli-broccoli
    </td>
  </tr>
  <tr>
    <th align=left>
      New version
    </td>
    <td>
      0.17.2
    </td>
  </tr>
  <tr>
    <th align=left>
      Type
    </td>
    <td>
      dependency
    </td>
  </tr>
</table>

This version is **not covered** by your **current version range**.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of ember-cli-broccoli.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and while I’m just a bot, there is a group of people who are happy to teach me new things. [Let them know](https://github.com/greenkeeperio/greenkeeper/issues/new).

Good luck with your project ✨

You rock!

🌴

---
The new version differs by 5 commits .

- [`deab2f0`](ember-cli/broccoli@deab2f0) <code>release v0.17.2</code>
- [`9c9f5b6`](ember-cli/broccoli@9c9f5b6) <code>Merge pull request #8 from ember-cli/fix-string-description</code>
- [`9334ff8`](ember-cli/broccoli@9334ff8) <code>Improve output by giving string nodes a better description.</code>
- [`9317eb0`](ember-cli/broccoli@9317eb0) <code>Merge pull request #7 from bantic/patch-4</code>
- [`a4d1ffc`](ember-cli/broccoli@a4d1ffc) <code>Update github repo, homepage in package.json</code>

See the [full diff](ember-cli/broccoli@4a4c52e...deab2f0).

---
This pull request was created by [greenkeeper.io](https://greenkeeper.io/).

<sub>Tired of seeing this sponsor message? ⚡ `greenkeeper upgrade`</sub>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanpenner @joefiorini @fsmanuel