Make use of ci-info for detecting CI environments
#8110
Conversation
tests/acceptance/new-test.js
Outdated
| })); | ||
|
|
||
| afterEach(function() { | ||
| if (ORIGINAL_PROCESS_ENV_CI === undefined) { | ||
| delete process.env.CI; | ||
| delete ci.isCI; |
There was a problem hiding this comment.
I don’t think we ever want to delete here. I’m also unsure how these tests can reliably pass (because now we don’t consistently control the CI state).
gowthamrm
force-pushed
the
implement_ci_info
branch
2 times, most recently
from
06f1c3c
to
f14c43d
Compare
gowthamrm
force-pushed
the
implement_ci_info
branch
from
f14c43d
to
8926987
Compare
|
@rwjblue @kellyselden Thank you for your review comments. I have made the suggested changes and updated it here. Please have a look and let know if it is good to go. |
gowthamrm
force-pushed
the
implement_ci_info
branch
from
8926987
to
a53603f
Compare
|
@rwjblue Can you please check on this? Is there anything else need to be done? |
| @@ -1,12 +1,12 @@ | |||
| 'use strict'; | |||
|
|
|||
| const { isCI } = require('ci-info'); | |||
There was a problem hiding this comment.
if we wanted to do this we would need to add an explicit ci-info dependency to every app 🤔
There was a problem hiding this comment.
as an alternative we could reexport the isCI variable ofci-info from ember-cli. might be the simpler alternative 🤔
|
@gowthamrm do you have time to work on this again? |
|
I'm going to close this for now (rebasing will be difficult), but I am absolutely still interested in migrating to usage of |
Fixed #8093
Replaced the usage of
process.env.CIandprocess.env.TRAVISwithrequire('ci-info').isCI