Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing dependencies (ember-qunit, @ember/test-helpers, qunit, qunit-dom) #9335

Closed
10 of 15 tasks
rwjblue opened this issue Sep 21, 2020 · 4 comments
Closed
10 of 15 tasks
Assignees

Comments

@rwjblue
Copy link
Member

rwjblue commented Sep 21, 2020

A major version release of the testing libraries is afoot! The goals of the next iteration are:

  • Drop support for older unsupported Node versions
  • Be more Embroider compatible
  • Do less "weird stuff"
  • Give versioning control back to applications (aka "do less bad magic")

Concretely, those goals result to the following major changes in ember-qunit@5 :

  • Drop support for older Node versions
  • Remove usage of APIs that are not Embroider compatible
    • {{content-for usage has been replaced by having the tests/index.html directly include our expected DOM content
    • app.import has been removed in favor of leveraging imports along with ember-auto-import / Embroider to process them
  • Move qunit and @ember/test-helpers into project devDependencies (ember-qunit is moving them to be peerDependencies along with some helpful validations and error messages to help guide folks down the path)

Roll out work:

@scalvert
Copy link
Contributor

What can I do to help?

@rwjblue
Copy link
Member Author

rwjblue commented Oct 21, 2020

FYI - This landed in ember-cli@3.23.0-beta.1.

@bertdeblock
Copy link
Contributor

Anything left to be done or can we close this issue?

@rwjblue rwjblue closed this as completed Oct 4, 2021
@rwjblue
Copy link
Member Author

rwjblue commented Oct 4, 2021

Thanks @bertdeblock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants