Embroider addon compatibility

[thoov]

This issue tracks embroider compatibility across the top section of addons in the community with the goal of getting help from others to improve embroiders compatibility. We have created test helpers that can be added to addons to validate that they work in embroider in both safe and optimized variants via ember-try scenarios. Below is a list of the top 25 addons (according to emberobserver.com) and their current state. If you are able to work on adding @embroider/test-setup (instructions can be found here) please reference this issue so I can keep this list updated.

• ember-test-helpers Add @embroider/test-setup to test against embroider emberjs/ember-test-helpers#989 (only tests embroider-safe ATM)
• ember-test-waiters add embroider scenarios emberjs/ember-test-waiters#303
• ember-cli
• ember-resolver
• ember-qunit
• ember-concurrency
• ember-test-selectors Add Embroider's test-setup package mainmatter/ember-test-selectors#670
• ember-cli-mirage Added embroider-safe and embroider-optimized to the test scenarios miragejs/ember-cli-mirage#2184
• ember-basic-dropdown [WIP] Add @embroider/test-setup to scenarios cibernox/ember-basic-dropdown#613
• ember-power-select
• ember-cli-string-helpers
• ember-cli-code-coverage Re-architect plugin loading and asset detection logic (add Embroider support) ember-cli-code-coverage/ember-cli-code-coverage#327
• ember-svg-jar
• ember-in-viewport
• ember-angle-bracket-invocation-polyfill (angle brackets are fully supported since Ember v3.10)
• ember-cli-postcss (not needed, using postcss-loader would make more sense instead of a dedicated Ember addon)
• ember-modal-dialog Embroider support yapplabs/ember-modal-dialog#370
• ember-changeset
• ember-power-calendar (seems unmaintained)
• ember-tooltips
• ember-sortable Embroider support adopted-ember-addons/ember-sortable#469
• ember-cp-validations
• ember-changeset-validations
• ember-math-helpers
• ember-cli-flash Add @embroider/test-setup to ember-try scenarios adopted-ember-addons/ember-cli-flash#360
• ember-lifeline
• ember-infinity Add @embroider/test-setup to ember-try scenarios adopted-ember-addons/ember-infinity#451
• ember-engines
• ember-cli-eyeglass (seems unmaintained)

[NullVoxPopuli]

has this list been updated? I think more of these are compat now?

[bertdeblock]

@NullVoxPopuli I've updated the list as best as I could, please let me know if anything else should be checked off.

[NullVoxPopuli]

Some of these can't be v2 addons, and maybe may never need embroider compatibility?

Like ember-cli-postcss is often used with Tailwind, and the ideal tailwind setup works best with webpack-native plugins (or as a separately running build)

And the polyfills... should be easy tests.

[bertdeblock]

Does ember-angle-bracket-invocation-polyfill need to be Embroider compat?
Angles are fully supported in Ember v3.10+, so might be overkill?

[bertdeblock]

Is this issue still needed / relevant?

[bertdeblock]

I updated the list a bit more, but going to close this for now. I think for the most part, this ticket has served its use.
I suggest specific tickets are created in the appropriate repo's if needed.