Add @embroider/test-setup to test against embroider #989
Conversation
stefanpenner
force-pushed
the
test-embroider
branch
from
9c13c05
to
b607aa3
Compare
|
I've rebased this, the failing tests are due to the ember-cli-typescript used in this project, which as implemented is not compatible with embroider. I intend to address next. |
stefanpenner
force-pushed
the
test-embroider
branch
from
96b3a73
to
538c272
Compare
stefanpenner
force-pushed
the
test-embroider
branch
5 times, most recently
from
67a1f45
to
ba243c1
Compare
stefanpenner
force-pushed
the
test-embroider
branch
16 times, most recently
from
3be3811
to
a2e470e
Compare
|
A small bonus: before: > rm API.md && time yarn docs
Done in 22.35s.
________________________________________________________
Executed in 23.28 secs fish external
usr time 23.74 secs 59.00 micros 23.74 secs
sys time 2.56 secs 671.00 micros 2.56 secsafter: > rm API.md && time yarn docs
Done in 1.37s.
________________________________________________________
Executed in 1.54 secs fish external
usr time 1385.11 millis 68.00 micros 1385.04 millis
sys time 209.11 millis 760.00 micros 208.35 millisAnd |
stefanpenner
force-pushed
the
test-embroider
branch
from
a2e470e
to
3b4a57c
Compare
| new MergeTrees([input, tsTree]), | ||
| 'addon-test-support:merged' | ||
| ); | ||
| if (this.isDevelopingAddon()) { |
There was a problem hiding this comment.
@rwjblue this simplifies development, quickly removing the need to run a separate "TS build" process.
I wouldn't consider this a final product, but demonstrates the viability "TS in dev + precompiled on publish approach"
When you have time, we should discuss
There was a problem hiding this comment.
I'd like to understand this more too. I'm not entirely sure what you mean when you refer to "TS in dev + precompiled on publish approach", because that describes what's done today - we use TS in dev, and precompile for releases.
There was a problem hiding this comment.
the comment was more based on an intermediate step + discussion with rob.
Functionally this appears the same as prior, but no longer requires ember-cli-typescript, which changed the above in the most recent versions.
There was a problem hiding this comment.
As yes, I remember this. This was the removal of the incremental-typescript-compiler from 1.5.0 -> 2.0.0. Makes sense.
|
GH actions appears to be queued up... Will poke back later... |
stefanpenner
force-pushed
the
test-embroider
branch
from
3b4a57c
to
298b000
Compare
| new MergeTrees([input, tsTree]), | ||
| 'addon-test-support:merged' | ||
| ); | ||
| if (this.isDevelopingAddon()) { |
There was a problem hiding this comment.
I'd like to understand this more too. I'm not entirely sure what you mean when you refer to "TS in dev + precompiled on publish approach", because that describes what's done today - we use TS in dev, and precompile for releases.
- run floating deps + try scenarios in node 12. This is to minimize frustrating test failures due to package drift, and to allow for testing embroider in CI. While officially supporting node 10 when not using embroider - upgrade all other viable deps - move to simple tsc -b approach - only run embroider-safe, as embroider-optimized is not yet compatible with our tests
stefanpenner
force-pushed
the
test-embroider
branch
from
298b000
to
6828d0c
Compare
Adds 2 test cases against embroider for ember-try.