[ENHANCEMENT] Update ember-cli-babel to v8 in app and addon blueprints
#10141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2023
|
embroider-build/embroider#1343 should fix the failing Embroider runs. |
bertdeblock
force-pushed
the
update-ember-cli-babel-in-blueprints
branch
from
25c04f1
to
35bef7d
Compare
bertdeblock
force-pushed
the
update-ember-cli-babel-in-blueprints
branch
from
35bef7d
to
d7db292
Compare
| @@ -56,6 +56,11 @@ module.exports = { | |||
| contents.dependencies['ember-cli-babel'] = contents.devDependencies['ember-cli-babel']; | |||
| delete contents.devDependencies['ember-cli-babel']; | |||
|
|
|||
| // Addons must bring in their own version of `@babel/core` | |||
| // when using `ember-cli-babel` >= v8. | |||
| contents.dependencies['@babel/core'] = contents.devDependencies['@babel/core']; | |||
There was a problem hiding this comment.
why a dependencies entry?
shouldn't this be a peer(+dev), letting the app control the version?
There was a problem hiding this comment.
@bertdeblock provided some context here: https://github.com/babel/ember-cli-babel/blob/master/UPGRADING.md#upgrade-path-for-addons
tl;dr: v1 addons already don't care what the app is doing, as they compile themselves
There was a problem hiding this comment.
I've added that link as well over in #10349.
NullVoxPopuli
approved these changes
Aug 18, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly opening to see how CI will respond.
Closes #9933.
Closes #9934.
Closes emberjs/ember-cli-babel#453.