[ENHANCEMENT] Add v4.8 LTS to addon blueprint - Remove v3.28 LTS and ember-classic scenario
#10189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
changed the title
addon blueprint - remove v4.4 LTS and ember-classic scenarioaddon blueprint - Remove v4.4 LTS and ember-classic scenario
kategengler
reviewed
Feb 21, 2023
|
I think the peerDep on ember-source in the blueprint should remain pretty loose, other than that, it lgtm. |
bertdeblock
changed the title
addon blueprint - Remove v4.4 LTS and ember-classic scenarioaddon blueprint - Remove v3.28 LTS and ember-classic scenario
|
Given how ember-cli-update works, I think I agree with @kategengler that it's better to be looser here. Ideally, we could put the stricter value here for newly-generated addons without accidentally causing upgrading addons to break their users unnecessarily. But that would require changes to ember-cli-update so that this peer dep (and the ember-try config) get a different update strategy. |
bertdeblock
force-pushed
the
update-scenarios-in-addon-blueprint
branch
from
784aa45
to
c5b3633
Compare
|
Thanks both! Updated the PR accordingly. |
bertdeblock
force-pushed
the
update-scenarios-in-addon-blueprint
branch
from
c5b3633
to
73cb828
Compare
kategengler
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.