Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP] Update blueprint ignore files #10229

Merged
merged 2 commits into from
Apr 5, 2023
Merged

[CLEANUP] Update blueprint ignore files #10229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8a79db
Update blueprint ignore files
bertdeblock Mar 30, 2023
cf4329d
Merge branch 'master' into update-blueprint-ignore-files
kategengler Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions blueprints/app/files/.eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,13 @@
# unconventional js
/blueprints/*/files/
/vendor/
Copy link
Contributor Author

@bertdeblock bertdeblock Mar 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed from the default blueprint in #10050.
Theoretically, should not be needed anymore in new Ember apps and addons.


# compiled output
/dist/
/tmp/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used anymore in new Ember apps.


# dependencies
/node_modules/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint ignores node_modules by default:
https://eslint.org/docs/latest/use/configure/ignore#the-eslintignore-file


# misc
/coverage/
!.*
.*/
.eslintcache
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't lint its own cache file.


# ember-try
/.node_modules.ember-try/
/npm-shrinkwrap.json.ember-try
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not .js or .ts files, so no need to list these.

/package.json.ember-try
/package-lock.json.ember-try
/yarn.lock.ember-try
12 changes: 1 addition & 11 deletions blueprints/app/files/.prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,13 @@
# unconventional js
/blueprints/*/files/
/vendor/

# compiled output
/dist/
/tmp/

# dependencies
/node_modules/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier ignores node_modules by default:
https://prettier.io/docs/en/ignore.html#ignoring-files-prettierignore


# misc
/coverage/
!.*
.eslintcache
.lint-todo/
.*/

# ember-try
/.node_modules.ember-try/
/npm-shrinkwrap.json.ember-try
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not picked up by Prettier, so no need to list these.

/package.json.ember-try
/package-lock.json.ember-try
/yarn.lock.ember-try
2 changes: 1 addition & 1 deletion blueprints/app/files/.watchmanconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"ignore_dirs": ["tmp", "dist"]
"ignore_dirs": ["dist"]
}
6 changes: 0 additions & 6 deletions blueprints/app/files/gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,14 @@
# See https://help.github.com/ignore-files/ for more about ignoring files.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link doesn't work anymore.


# compiled output
/dist/
/tmp/

# dependencies
/node_modules/

# misc
/.env*
/.pnp*
/.sass-cache
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apps or addons that use SASS, should include this explicitly.

/.eslintcache
/connect.lock
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never seen this being created. I assume it's something that was needed a long time ago.

/coverage/
/libpeerconnection.log
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never seen this being created. I assume it's something that was needed a long time ago.

/npm-debug.log*
/testem.log
/yarn-error.log
Expand Down