Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Deprecate Travis CI support #10350

Merged
merged 4 commits into from Oct 20, 2023

Conversation

bertdeblock
Copy link
Contributor

@bertdeblock bertdeblock commented Aug 21, 2023

Implements emberjs/rfcs#918.

The first commit isn't a necessity, but I think it makes deprecations more readable (a bit "heavier" though).

Example:

Screenshot 2023-08-21 at 16 48 46 (2)

@bertdeblock bertdeblock changed the title Deprecate Travis CI support [ENHANCEMENT] Deprecate Travis CI support Aug 21, 2023
@bertdeblock bertdeblock force-pushed the deprecate-travis-ci-support branch 2 times, most recently from 7604782 to 1404809 Compare August 21, 2023 15:27
locks
locks previously requested changes Aug 28, 2023
blueprints/addon/files/.travis.yml Outdated Show resolved Hide resolved
blueprints/app/files/.travis.yml Outdated Show resolved Hide resolved
lib/commands/init.js Outdated Show resolved Hide resolved
tests/fixtures/addon/defaults-travis/.travis.yml Outdated Show resolved Hide resolved
tests/fixtures/addon/yarn/.travis.yml Outdated Show resolved Hide resolved
tests/fixtures/app/npm-travis/.travis.yml Outdated Show resolved Hide resolved
tests/fixtures/app/yarn-travis/.travis.yml Outdated Show resolved Hide resolved
@locks
Copy link
Contributor

locks commented Aug 28, 2023

Opened a PR so we can get a good idea of the final link: ember-learn/deprecation-app#1338.

Copy link
Member

@kategengler kategengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending url updates

@ef4
Copy link
Contributor

ef4 commented Oct 13, 2023

The RFC for this is now Ready to Release, so this can be released and should be reported back on emberjs/rfcs#978

@kategengler kategengler marked this pull request as ready for review October 20, 2023 15:28
@kategengler kategengler merged commit db9e195 into ember-cli:master Oct 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants