New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Deprecate Travis CI support #10350
Merged
kategengler
merged 4 commits into
ember-cli:master
from
bertdeblock:deprecate-travis-ci-support
Oct 20, 2023
Merged
[ENHANCEMENT] Deprecate Travis CI support #10350
kategengler
merged 4 commits into
ember-cli:master
from
bertdeblock:deprecate-travis-ci-support
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
changed the title
Deprecate Travis CI support
[ENHANCEMENT] Deprecate Travis CI support
Aug 21, 2023
bertdeblock
force-pushed
the
deprecate-travis-ci-support
branch
2 times, most recently
from
August 21, 2023 15:27
7604782
to
1404809
Compare
bertdeblock
commented
Aug 21, 2023
locks
previously requested changes
Aug 28, 2023
tests/fixtures/app/with-blueprint-override-lint-fail/.travis.yml
Outdated
Show resolved
Hide resolved
Opened a PR so we can get a good idea of the final link: ember-learn/deprecation-app#1338. |
Merged
9 tasks
kategengler
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending url updates
The RFC for this is now Ready to Release, so this can be released and should be reported back on emberjs/rfcs#978 |
Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
kategengler
force-pushed
the
deprecate-travis-ci-support
branch
from
October 20, 2023 15:27
3333c6a
to
7b31e5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements emberjs/rfcs#918.
The first commit isn't a necessity, but I think it makes deprecations more readable (a bit "heavier" though).
Example: