Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update optional-features.json #10440

Merged
merged 3 commits into from Feb 29, 2024
Merged

Update optional-features.json #10440

merged 3 commits into from Feb 29, 2024

Conversation

achambers
Copy link
Member

@achambers achambers commented Feb 7, 2024

Adding no-implicit-route-model for emberjs/rfcs#970

TODO

  • Modify this to default to true

@achambers achambers marked this pull request as ready for review February 14, 2024 15:26
@achambers achambers marked this pull request as draft February 14, 2024 15:32
@mansona
Copy link
Member

mansona commented Feb 14, 2024

The CI is failing with the message:

Unknown feature "no-implicit-route-model" found in config/optional-features.json

Does this mean that we can't merge this until the version of ember-source that defines this optional feature is actually released? I don't know if we've done any version guarding on optional-features before 🤔

@mansona
Copy link
Member

mansona commented Feb 14, 2024

Ah looking into it it's probably because @ember/optional-features hasn't been shipped. I'll work on get that released and this should start passing, and we should probably bump the version in the blueprint too to be safe ;)

@achambers achambers changed the base branch from master to beta February 21, 2024 15:15
achambers and others added 3 commits February 28, 2024 17:57
Adding `no-implicit-route-model` for emberjs/rfcs#970
Co-authored-by: Chris Manson <mansona@users.noreply.github.com>
@kategengler kategengler marked this pull request as ready for review February 29, 2024 14:46
@kategengler kategengler merged commit 5f59f02 into beta Feb 29, 2024
11 checks passed
@kategengler kategengler deleted the achambers-patch-1 branch February 29, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants