Specified the locale in setupIntl() #10464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ember-intl@v7
, the test helpersetupIntl()
requires end-developers to specify a locale. I updated the blueprint file fortests/helpers/index.ts
to reflect this breaking change.Note
The change to
tests/helpers/index.ts
is backward-compatible, because specifying the locale is optional in earlier versions ofember-intl
.Two possible alternatives:
setupApplicationTest()
, because the test helpersetupIntl()
is really meant to help end-developers write rendering and unit tests.setupRenderingTest()
, in case an end-developer wants an example of calling a function (e.g.setupIntl()
) in all or most rendering tests.