[WIP] Update core object

[jgwhite]

Current status: still testing against addons.

[chadhietala]

Can we rename this to preprocessors?

[stefanpenner]

👍

[jgwhite]

Totally.

[krisselden]

@jgwhite after working with the old core object, I'm a big fan of this.

[jgwhite]

This now passes but the changes are extensive. 😬

Making the switch without breaking our existing crop of addons involves two awkward contortions:

• Project detects and uses the appropriate constructor signature for addons
• A modified version of core-object that makes the _super available as _super.someMethod

Other concerns:

• Omitting the this._super.apply(this, arguments) in init will almost always break things
• The difference between CoreObject#init and Ember.CoreObject#init may cause confusion

[stefanpenner]

Omitting the this._super.apply(this, arguments) in init will almost always break things

we can fn.toString().indexOf('._super') and log a depreciation

Project detects and uses the appropriate constructor signature for addons

this should likely raise a deprecation (as i believe this will be a fail without)

[trabus]

Wow, awesome work! 👏

[stefanpenner]

@jgwhite im nervous that this is getting way out of sync. Ping me, I would like to be sure to unblock you, or take the reigns before we diverge entirely, I would love to get this in asap.

[jgwhite]

@stefanpenner I’ve been rebasing fairly regularly and I believe this is in a mergeable state right now.

[jgwhite]

Oops. Spoke too soon!

[stefanpenner]

@jgwhite we should sync up, ping me when you are free. Would love to unblock you :)

[jgwhite]

@stefanpenner I’ve been trying to find a way to roll out the new CoreObject without changing exsting libraries but, the more I look at it, the more I think this will need a symlink-style unilateral upgrade. It’s mainly variations in expectations around init that cause trouble.

broccoli-caching-writer is a particularly off-beat culprit. What do you think of releasing a new-core-object-friendly version: ember-cli/broccoli-caching-writer@ember-cli:master...jgwhite:upgrade-core-object

[stefanpenner]

@jgwhite im not quite sure what that external lib was causing grief. But it does not need to change (and also no longer uses core object itself at all)

[stefanpenner]

@jgwhite do you have interest in landing this, or should we close and revist later?

[jgwhite]

@stefanpenner much as it pains me to say it — let’s close and revisit later.

[stefanpenner]

@jgwhite NP, future work :)