Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Architecture Diagram #3501

Merged
merged 1 commit into from
Mar 16, 2015

Conversation

visheshjoshi
Copy link

Added architecture diagram to ARCHITECTURE.md.

@stefanpenner
Copy link
Contributor

awesome, maybe we should use omni graffle, and also commit the file. So its easy to maintain/update.

@visheshjoshi
Copy link
Author

I used https://www.draw.io/ to draw this, which allows exporting to xml.
@stefanpenner Do you think committing the xml might work?
Also do you think putting it in an assets folder might be a good idea?

@stefanpenner
Copy link
Contributor

@stefanpenner Do you think committing the xml might work?

👍

@stefanpenner
Copy link
Contributor

Also do you think putting it in an assets folder might be a good idea?

👍

@stefanpenner
Copy link
Contributor

@visheshjoshi got a chance to add the XML ?

@visheshjoshi
Copy link
Author

@stefanpenner Just did.

@stefanpenner
Copy link
Contributor

@visheshjoshi mind squashing the commits? Then we should be good to go.

@stefanpenner
Copy link
Contributor

@trabus a diagram like this, might help people understand that boot process. And, likely some of the pod stuff we have planned.

@ghost
Copy link

ghost commented Mar 16, 2015

@stefanpenner looks like the appveyor tests timed out. Mind restarting them?

@stefanpenner
Copy link
Contributor

i have confidence these doc improvements didn't actually break windows CI. merging, thanks dude!

stefanpenner added a commit that referenced this pull request Mar 16, 2015
@stefanpenner stefanpenner merged commit 26f57b6 into ember-cli:master Mar 16, 2015
@stefanpenner
Copy link
Contributor

@visheshjoshi although this is awesome, are you interested in experimenting the diagram to use: https://github.com/knsv/mermaid ?

@visheshjoshi
Copy link
Author

@stefanpenner Will take a look at mermaid and update the diagram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants