Add ability to start ember serve on https #3550
Conversation
drogus
force-pushed
the
allow-to-serve-app-on-ssl
branch
2 times, most recently
from
8a07916
to
f03d95d
Compare
|
I like the idea, i would like to play with it myself to see how it feels. |
|
@drogus got time to get tests green? |
|
@drogus friendly ping |
| return subject.start({ | ||
| host: '0.0.0.0', | ||
| port: '1337', | ||
| ssl: true |
select tests:
debugging: either set a debugger inline, or use the various debugger API's: https://nodejs.org/api/debugger.html npm run test:debughttps://github.com/ember-cli/ember-cli/blob/master/package.json#L13 |
|
@drogus i hope this is enough info to help you make progress, let me know if i can help you further. for some reason GH wouldn't let me PR to your fork, here is a branch i have rebased and made some fixes too: https://github.com/ember-cli/ember-cli/tree/pr-3550 pending work:
|
|
I'm sorry for a delay, my notifications setup was screwed up. I'll work on it today, thanks for tips, that should get me going! |
:) |
drogus
force-pushed
the
allow-to-serve-app-on-ssl
branch
from
f03d95d
to
f7d4127
Compare
| }) | ||
| .then(function() { | ||
| return new Promise(function(resolve, reject) { | ||
| process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0"; |
There was a problem hiding this comment.
@stefanpenner the intention of this test was to check if we really start server over https, so I wanted to make a request that succeeds. I found out that the easiest way is to set process.env.NODE_TLS_REJECT_UNAUTHORIZED to 0, to not get an error without setting ca.
drogus
force-pushed
the
allow-to-serve-app-on-ssl
branch
2 times, most recently
from
45bbc69
to
188c331
Compare
|
It should be green now. Io.js tests fail, but I see them failing also on other branchs/prs, so that's rather not caused by my code. |
|
the io.js failure appears different then the rest. The rest are actually the same test, that just happens to be brittle on travis. I am unable to reproduce it locally, on linux or OS X. :( Anyways, re-kicked travis |
|
I see the same issue here: https://travis-ci.org/ember-cli/ember-cli/jobs/61259446#L1843-L1848 Anyways, I can have a look at that as well. |
|
ya hmm.. 17 hours ago we got a green build: https://travis-ci.org/ember-cli/ember-cli/builds/61205147 which should be master. It just take a-few runs. |
|
@jayphelps looks like you appveyor has hijacked ember-cli's ? https://ci.appveyor.com/project/jayphelps/ember-cli/build/230 |
|
some strange interleavings are happening with appveyor. https://ci.appveyor.com/project/embercli/ember-cli/build/2643 seems to be green. |
drogus
force-pushed
the
allow-to-serve-app-on-ssl
branch
from
188c331
to
58a31f5
Compare
|
@stefanpenner I don't even |
Sometimes it may be needed to run an app locally with SSL. This commit adds an --ssl option, which tries to run on https. Default ssl certificate and ssl key paths are "ssl/server.crt" and "ssl/server.key" respectively. Custom paths can be added with --ssl-cert and --ssl-key
drogus
force-pushed
the
allow-to-serve-app-on-ssl
branch
from
9685a6c
to
6eadb5e
Compare
|
@stefanpenner it seems that tests pass after rebasing to master. Should I squash commits? Does the code look OK? |
| this.httpServer = this.http.createServer(this.app); | ||
| if (this.startOptions.ssl) { | ||
| if(!fs.existsSync(this.startOptions.sslKey)) { | ||
| throw new TypeError('Ssl key couldn\'t be found in "' + this.startOptions.sslKey + '", please provide a path to an existing ssl key file with --ssl-key'); |
|
|
@stefanpenner I'm not sure what's going on with coveralls, but after my last push (I extracted https server creation and fixed typos) it's green |
Add ability to start ember serve on https
Sometimes it may be needed to run an app locally with SSL. This PR
adds an --ssl option, which tries to run on https. Default ssl
certificate and ssl key paths are "ssl/server.crt" and "ssl/server.key"
respectively. Custom paths can be added with --ssl-cert and --ssl-key.
Tests don't pass, because I suck at node and npm and I have no idea how to run only
one file (and running all tests is too slow to debug it easily). Additionally I'm not sure
how to pass ssl options to
subjectin the test. They're used insetupHttpServer, but the test error says it'sundefined. The weird thing is thatssloption apparently is passed through correctly, because it reaches a check forsslKey. Any help is appreciated.