add command uninstall:npm #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easy port of `ember install:npm`
|
Awesome! so uninstall remove from |
| // misplaced console.log | ||
| this.disableLogger(); | ||
|
|
||
| this.npm.load(npmOptions, function(err) { |
There was a problem hiding this comment.
can we use Promise.denodeify for this node-back?
|
@stefanpenner I made changes based on your code review.
|
|
awesome, thanks @kellyselden |
stefanpenner
added a commit
that referenced
this pull request
Mar 23, 2015
add command uninstall:npm
| .finally(this.finally.bind(this)) | ||
| .then(this.announceCompletion.bind(this)); | ||
| }, | ||
|
|
||
| announceCompletion: function() { | ||
| announceCompletion: function(data) { | ||
| this.printPackageNames(data); |
There was a problem hiding this comment.
this isn't optimal during a fresh install or `init see #3616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #3582. Left out bower because of the deprecation. Basically a port of
ember install:npm.