Use broccoli-funnel instead of broccoli-static-compiler #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome, by sure though that: |
|
tests failures look race related. I suspect we recently regressed on something related... in all likely-hood one of or deps has a race again... |
|
this appears to be a duplicate of: #3621 |
Ah, yes, now I'm getting the tests to cover my code. So things are OK then. Travis is green too. Re dup, I caught a few extra lines I think, so you should prefer my PR :) |
|
Ya. Done :) |
stefanpenner
added a commit
that referenced
this pull request
Mar 27, 2015
Use broccoli-funnel instead of broccoli-static-compiler
|
Gotta figure out those races. These brittle tests have been getting worse this week |
|
ah, I forgot add-ons depend on having access to |
| @@ -364,7 +363,7 @@ Addon.prototype.treeForPublic = function(tree) { | |||
| return tree; | |||
| } | |||
|
|
|||
| return this.pickFiles(tree, { | |||
There was a problem hiding this comment.
specifically this case.
stefanpenner
added a commit
that referenced
this pull request
Mar 27, 2015
DanielOchoa
pushed a commit
to DanielOchoa/ember-cli
that referenced
this pull request
Mar 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broccoli-funnel has the
allowEmptyoption that we needed CustomStaticCompiler for.I didn't get any failing tests, so I'm not 100% sure that the code in
lib/models/addon.jsworks properly, but it definitely looks correct. :)