Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add testem --launch option to ember test command #3703

Merged
merged 1 commit into from Mar 31, 2015

Conversation

jrjohnson
Copy link
Contributor

Passing a list of of launchers into testem like this allows for more control over the setup in a CI environment.

Specifically a Saucelabs testem.json setup like this:

"launchers": {
    "SauceLabs_Chrome": {
      "command": "./node_modules/.bin/ember-cli-sauce --platformSL='Windows 7' --no-ct -u <url>",
      "protocol": "tap"
    },
    "SauceLabs_Firefox": {
      "command": "./node_modules/.bin/ember-cli-sauce --platformSL='Windows 7' --browserNameSL='firefox' --no-ct -u <url>",
      "protocol": "tap"
    },
}

And a travis setup like this:

matrix:
  fast_finish: true
  allow_failures:
    - env: "LAUNCHER='SauceLabs_Firefox'
  include:
    - env: "LAUNCHER='SauceLabs_Chrome'
script:
  - ember test --launch=${LAUNCHER}

Would make it possible to:

  1. Run each browser tests in paralel
  2. Allow some browsers to fail without the build failing

@jrjohnson jrjohnson changed the title ENHANCEMENT: Add testem --launch option to ember test command [ENHANCEMENT] Add testem --launch option to ember test command Mar 30, 2015
@@ -55,6 +56,9 @@ module.exports = Command.extend({
var testPageJoinChar = containsQueryString ? '&' : '?';

originalContents['test_page'] = originalContents['test_page'] + testPageJoinChar + this.buildTestPageQueryString(options);
if(options.launch){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing whitespace

@stefanpenner
Copy link
Contributor

i am a fan!

@stefanpenner stefanpenner modified the milestones: v0.2.2, v0.3.0 Mar 30, 2015
@stefanpenner
Copy link
Contributor

@johanneswuerbach your our resident testem guru, what are your thoughts?

@stefanpenner
Copy link
Contributor

@jrjohnson can you rebase, I added some improvements to help mitigate the sporadic appveyor failures

@johanneswuerbach
Copy link
Contributor

👍 thanks @jrjohnson I really like it.

Pass through a list of launchers to testem to control the test
environment.
@jrjohnson
Copy link
Contributor Author

Rebased and I went ahead and squashed the commits as well.

stefanpenner added a commit that referenced this pull request Mar 31, 2015
[ENHANCEMENT] Add testem --launch option to ember test command
@stefanpenner stefanpenner merged commit 8a012c2 into ember-cli:master Mar 31, 2015
@jrjohnson jrjohnson deleted the specify-testem-launcher branch March 31, 2015 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants