Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return currentURL() rather than path, ref #3719 #3755

Merged

Conversation

shellandbull
Copy link
Contributor

Originally referenced on #3719, in this PR I have:

  • Updated the fixture, replacing currentPath() for currentUrl()
  • Changed the template accordingly

@shellandbull
Copy link
Contributor Author

 1 failing

  1) Acceptance: ember generate pod adapter foo/bar --pod:
     Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.
      at null.<anonymous> (C:\projects\ember-cli\node_modules\mocha\lib\runnable.js:170:19)
      at Timer.listOnTimeout (timers.js:110:15)

Looks like this fail is unrelated to my branch could be a random fail @jgwhite ?

@jgwhite
Copy link
Contributor

jgwhite commented Apr 2, 2015

Yeah, appveyor isn’t super reliable. Restarting the build.

@jgwhite
Copy link
Contributor

jgwhite commented Apr 2, 2015

@ember-cli/owners I’m struggling to decipher this AppVeyor failure. Any cause for concern?

@stefanpenner
Copy link
Contributor

looks like it is rebuilding... lets wait it out.

@stefanpenner stefanpenner added this to the v0.2.3 milestone Apr 2, 2015
stefanpenner added a commit that referenced this pull request Apr 3, 2015
@stefanpenner stefanpenner merged commit 9d330ee into ember-cli:master Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants