Throw if templating a file fails #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 4, 2015
|
I'm going through the upgrade steps for my test-recorder then will link to this branch from my npm and run ember init again. |
| return content.toString(); | ||
| } | ||
| return lstat(path).then(function(fileStat) { | ||
| if (isBinaryFile(content, fileStat.size)) { |
There was a problem hiding this comment.
we should ad a test for binary files
There was a problem hiding this comment.
There already is one, see https://github.com/ember-cli/ember-cli/blob/master/tests/unit/models/file-info-test.js#L69
|
needs rebase |
Previously, if an error was thrown during the template rendering process, the error was simply swallowed. This was likely to avoid errors when attempting to template a binary file, since the byte stream, when converted to a string, could contain template markers. Adds the isbinaryfile package to detect if the file is binary. If so, it skips templating entirely. If not, it attempts to template the file, and allows exceptions to reject the render promise. This happened to expose some tests that should have been failing around the http-proxy generators (the tests were not supplying enough arguments). Fixes those tests too.
davewasmer
force-pushed
the
fail-fast-templating
branch
from
e5e374b
to
7a6173b
Compare
|
Rebased and addressed all the outstanding comments @stefanpenner |
|
kicking appveyor |
stefanpenner
added a commit
that referenced
this pull request
May 20, 2015
Throw if templating a file fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an error was thrown during the template rendering process, the error was simply swallowed. This was likely to avoid errors when attempting to template a binary file, since the byte stream, when converted to a string, could contain template markers.
Adds the isbinaryfile package to detect if the file is binary. If so, it skips templating entirely. If not, it attempts to template the file, and allows exceptions to reject the render promise.
This happened to expose some tests that should have been failing around the http-proxy generators (the tests were not supplying enough arguments). Fixes those tests too.