[BUGFIX] Prevent addon-import blueprint from generating if entity name is undefined #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 18, 2015
|
i suspect this needs a test of its own. |
trabus
force-pushed
the
addon-import-blueprint-normalize
branch
from
92b6018
to
dc3d2d3
Compare
trabus
force-pushed
the
addon-import-blueprint-normalize
branch
2 times, most recently
from
8e2316b
to
d71a00e
Compare
trabus
force-pushed
the
addon-import-blueprint-normalize
branch
3 times, most recently
from
d6f6635
to
180d93c
Compare
…g if entity name is undefined
trabus
force-pushed
the
addon-import-blueprint-normalize
branch
from
180d93c
to
9b27715
Compare
|
What's the status on this? |
|
It's ready to go, just needs a quick review. I've been rebasing along with the attempts to get appveyor passing. |
abuiles
added a commit
that referenced
this pull request
May 12, 2015
[BUGFIX] Prevent addon-import blueprint from generating if entity name is undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3831 by preventing addon-import blueprint from generating if entity name is undefined.
When running
ember install:addon ember-cli-foothe following silent error was being triggered:This PR fixes the silent error, but #3831 may require further work to solve any further root cause.