writeError now looks for filename as well as file #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagenet
force-pushed
the
write-error-jshint
branch
from
12788da
to
8b31ffe
Compare
| if (error.file) { | ||
| var file = error.file; | ||
| // Uglify errors have a filename instead | ||
| if (error.file || error.filename) { |
There was a problem hiding this comment.
Can you do var fileName = error.file || error.fileName; and then the conditional?
|
This will be handy! This also needs a test |
UglifyJS sets the filename but not the file. This change now gives us line and column for UglifyJS errors.
wagenet
force-pushed
the
write-error-jshint
branch
from
8b31ffe
to
d5cf74b
Compare
|
@stefanpenner, got your tests now |
|
restarting appveyor |
stefanpenner
added a commit
that referenced
this pull request
May 6, 2015
writeError now looks for filename as well as file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UglifyJS sets the filename but not the file. This change now gives
us line and column for UglifyJS errors.