[BUGFIX] Use posix path for in-repo-addons in package.json #3869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trabus
force-pushed
the
in-addon-npm-path
branch
from
85efb06
to
460fbf7
Compare
trabus
force-pushed
the
in-addon-npm-path
branch
2 times, most recently
from
6427ed7
to
0751b84
Compare
| @@ -22,7 +22,7 @@ module.exports = { | |||
| var packagePath = path.join(this.project.root, 'package.json'); | |||
| var contents = JSON.parse(fs.readFileSync(packagePath, { encoding: 'utf8' })); | |||
| var name = stringUtil.dasherize(options.entity.name); | |||
| var newPath = path.join('lib', name); | |||
There was a problem hiding this comment.
@trabus probably we can still use path, but make explicit that we want posix path.posix.join.
abuiles
added a commit
that referenced
this pull request
May 12, 2015
[BUGFIX] Use posix path for in-repo-addons in package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3847 using a posix style path in package.json for in-repo-addons for Windows (and all other environments).