Remove podModulePrefix from app.js #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was left over after removing `podModulePrefix` from the config. If not, just close this PR.
abuiles
added a commit
that referenced
this pull request
Apr 17, 2015
Remove podModulePrefix from app.js
|
@knownasilya thanks! |
This was referenced May 16, 2015
Closed
|
We're going to revert this for the time being, until we can ensure that podModulePrefix is no longer needed. With the current state of pods, we still need to support it. |
|
Sounds good, I think you'd also have to bring back the podModulePrefix in the config/environment.js file |
Actually, that part is fine, as it is optional in the config, the resolver handles the case when it's not defined. The problem was that when people did define it, the wiring was no longer there. |
|
Ah, makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was left over after removing
podModulePrefixfrom the config. If not, just close this PR.