Always create addon trees when developing an addon

[marcioj]

If we create a new addon and start the server includedModules() will return an empty object, since there isn't any module, so the addon tree is skipped.
But if later we add a new file, for instance using ember g initializer foo, these files aren't included in the pipeline because no tree was created initially and tests will fail with Could not find module ember-simple-validate/initializers/foo imported from dummy/initializers/foo

Fixes #3906

[marcioj]

Travis isn't helping today: sh: 1: istanbul: not found :(
Not sure if I'm doing something wrong here

[kellyselden]

I added the istanbul coverage, but I don't see anything that would cause this to stop working.

[marcioj]

Thanks for the reply @kellyselden.
I believe this is related with the travis ci cache.
Could you please cleanup the cache for this branch and restart the build?

[stefanpenner]

@marcioj i purged the cache, it seemed to solve this for other PR :)

[marcioj]

Thanks @stefanpenner!
Unfortunately my tests aren't passing in travis, I'll check it out tonight.

[stefanpenner]

@marcioj thanks :)

[marcioj]

After some debugging I found the issue. Looks like the process.env.EMBER_ADDON_ENV wasn't being properly cleaned in addon-test.js.
process.env.EMBER_ADDON_ENV = undefined will coerce the undefined value to a string, which will return the string 'undefined' when called. This affect the EMBER_ADDON_ENV normalization done in ember-addon.js, which will not setup the variable to 'development' because the 'undefined' string is present. And in the end will affect the Addon#isDevelopingAddon making it always return false and which make my tests fail since it's just intended to be used when the addon is being developed.
I changed addon-test.js to handle this.

[stefanpenner]

@marcioj nice find!

[marcioj]

I changed the way I was closing the test server to just send a q, like we do in the terminal.
Previously using killCliProcess was causing a problem of don't killing phantomjs processes, so other tests running phantomjs will hang forever.
Unfortunately sending the q in this way will throw other error which I sent a fix to testem in testem/testem#544.
With this fix I believe all will work. So we need to wait for this patch be merged and a new testem version be released.

[johanneswuerbach]

The fix is included in testem v0.8.2, thanks for the PR.

[marcioj]

Thanks for the release @johanneswuerbach !

[stefanpenner]

@johanneswuerbach <3

[marcioj]

@stefanpenner 👍 / 👎 ?