New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a verification step to fail the build when tests are filtered with .only #4035
Conversation
In the end it wasn't related to travis cache. |
151b92a
to
04e36de
Compare
When I changed |
Friendly ping |
sorry, i must have missed this one. |
not that i know of :S, maybe some issue do exist? Is this ready to go? |
No problem :)
I remember when I changed the glob expression to Anyway the changes related to |
Wait a second, I'm unsure why I added package.json and bower.json in the addon blueprint. Let me see what happens if I remove them. |
@stefanpenner now it's ready to go |
Add a verification step to fail the build when tests are filtered with .only
thank you kindly sir :) |
Previously I sent a PR with a missing
.only
in the tests, this made the whole build just run tests of one file. To prevent this problem I added a verification step as requested by @stefanpenner.