[BUGFIX] Fix custom blueprint options for destroy command #4104
Conversation
| // merge in blueprint availableOptions | ||
| var blueprint; | ||
| var debug = require('debug')('ember-cli/commands/destroy'); | ||
| try{ |
|
So now that I'm rethrowing the error, it actually exposed that the |
oh wow, good catch! |
trabus
force-pushed
the
destroy-fix
branch
2 times, most recently
from
ecc2eef
to
d5d30ea
Compare
|
This file-info unit test failure started after rebasing from master https://travis-ci.org/ember-cli/ember-cli/jobs/63214480#L1960 @stefanpenner I'll rebase after #4114 is merged |
merged |
|
@trabus can you rebase, i fixed some windows issue. be sure to review: https://ci.appveyor.com/project/embercli/ember-cli/history rather then the widget inlined in GH, as the widget for some reason points to @jayphelps's appveyor... |
|
I'm gonna contact their support and see if I can get it to stop pointing at mine some how...I imagine it was some sort of autodetection that picked it up when I was added ass a collab'r or something. |
|
I don't understand how coveralls is saying this decreased coverage, when I just added a test for the thing it was complaining about. It was previously decreased by -0.06%, but adding a test for what it was complaining about decreased it by -0.24%. |
…eptance tests to properly fail on an exitCode
…ning registerOptions
|
Maybe a rounding error? |
|
Wanna maybe extract the code in the catch block to a shared function? |
|
I'll try that later today. |
[BUGFIX] Fix custom blueprint options for destroy command
|
This PR fixes #4099 by adding custom blueprint options to the destroy command (previously was only added to the generate command). The
ember destroy component foo-bar -pcommand was failing because of the addition of an option that the__path__token depended upon.This PR also fixes all of the internal destroy acceptance tests by asserting that the destroy command returns an object instead of an errorCode.