Code Quality: addon.js, project.js D -> C #4146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, what other improvements did you have in mind? |
|
I was just thinking if there was a way to remove all duplication, but that might not even be possible, so this might just be it. |
stefanpenner
added a commit
that referenced
this pull request
May 22, 2015
Code Quality: addon.js, project.js D -> C
ah, ok. :) Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves some duplication in
lib/models/addon.jsandlib/models/project.js, as listed in #3730.It adds a new method to
lib/models/addon-discovery.jsto map the discovered packages.@stefanpenner This can be improved even further, but we should probably discuss if it's worth it in terms of readability.