remove duplication from normalize entity name #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'use strict'; | ||
| var SilentError = require('../errors/silent'); | ||
|
|
||
| module.exports = function(entityName) { |
There was a problem hiding this comment.
can you add an explicit test for this new extracted module?
basically for the two branches:
- test that it throws, with the correct error type and message
- test that it returns entityName
@tyleriguchi nice work! Let me know if you need any help with the tests. |
|
Added tests to confirm it throws an error and message, and that it returns an entity name |
stefanpenner
added a commit
that referenced
this pull request
May 23, 2015
remove duplication from normalize entity name
|
Thank you kindly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if this looks alright, first time contributing. In reference to #3730