Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a (now deprecated) single-argument use of addBowerPackageToProject #4643

Merged
merged 1 commit into from
Aug 10, 2015
Merged

Support a (now deprecated) single-argument use of addBowerPackageToProject #4643

merged 1 commit into from
Aug 10, 2015

Conversation

mike-north
Copy link
Member

A single-argument use of addBowerPackageToProject used to work, until #4430 . This is causing some problems ( Gaurav0/ember-cli-jquery-ui#14 )

For example

addBowerPackageToProject('jquery-ui#1.11.1');

This PR adds support for this use back in to ember-cli, and deprecates it since we eventually want to get everyone using the two-argument variant

addBowerPackageToProject('jquery-ui', '1.11.1');

stefanpenner added a commit that referenced this pull request Aug 10, 2015
…for-bower

Support a (now deprecated) single-argument use of addBowerPackageToProject
@stefanpenner stefanpenner merged commit 43719f9 into ember-cli:master Aug 10, 2015
deathbearbrown added a commit to deathbearbrown/ember-plupload that referenced this pull request Aug 12, 2015
deathbearbrown added a commit to deathbearbrown/ember-plupload that referenced this pull request Aug 12, 2015
deathbearbrown added a commit to deathbearbrown/ember-plupload that referenced this pull request Aug 12, 2015
@stavarotti
Copy link
Contributor

Any reason why the following now raises a deprecation notice?

this.addBowerPackageToProject('typography', 'https://github.xyz.com/UX/typography.git#1.0.1', {
  saveDev: true
})

Deprecation notice:

DEPRECATION: passing https://github.xyz.com/UX/typography.git#1.0.1 directly to `addBowerPackageToProject` will soon be unsupported.
You may want to replace this with `addBowerPackageToProject('https://github.xyz.com/UX/typography.git', '1.0.1')`

We use private repos that are not published to npm and hence the need to specify both the source and target. If we change to the recommended way, per the deprecation notice, we get an installation error:

Installing browser packages via Bower...
  not-cached https://github.xyz.com/UX/typography.git=https://github.xyz.com/UX/typography.git#1.0.1
Failed to execute "git ls-remote --tags --heads https://github.xyz.com/UX/typography.git=https://github.xyz.com/UX/typography.git", exit code of #128
fatal: https://github.xyz.com/UX/typography.git=https://github.xyz.com/UX/typography.git/info/refs not valid: is this a git repository?

Error: Failed to execute "git ls-remote --tags --heads https://github.xyz.com/UX/typography.git=https://github.xyz.com/UX/typography.git", exit code of #128
fatal: https://github.xyz.com/UX/typography.git=https://github.xyz.com/UX/typography.git/info/refs not valid: is this a git repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants