Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] close #5014 move git init to before npm and bower install #5017

Merged
merged 1 commit into from
Oct 30, 2015

Conversation

acburdine
Copy link
Contributor

Moves the git setup to the 'init' command process

Includes a check for the skipGit flag to be explicitly false, so that if it is 'undefined' it doesn't run.

return gitInit.run.bind(gitInit, commandOptions, rawArgs)();
}
})
.then(function() {
debug('after:installblueprint');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should move to before the git init, or to its own then.

@acburdine acburdine changed the title close #5014 move git init to before npm and bower install [BUGFIX] close #5014 move git init to before npm and bower install Oct 30, 2015
@kellyselden
Copy link
Member

Looks good!

@homu r+

@homu
Copy link
Contributor

homu commented Oct 30, 2015

📌 Commit 08b9106 has been approved by kellyselden

@homu
Copy link
Contributor

homu commented Oct 30, 2015

⌛ Testing commit 08b9106 with merge 3151386...

homu added a commit that referenced this pull request Oct 30, 2015
[BUGFIX] close #5014 move git init to before npm and bower install

Moves the git setup to the 'init' command process

Includes a check for the skipGit flag to be explicitly false, so that if it is 'undefined' it doesn't run.
@homu
Copy link
Contributor

homu commented Oct 30, 2015

☀️ Test successful - status

@homu homu merged commit 08b9106 into ember-cli:master Oct 30, 2015
@acburdine acburdine deleted the git-fix branch October 30, 2015 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants