Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.13.9 release #5045

Closed
wants to merge 1 commit into from
Closed

1.13.9 release #5045

wants to merge 1 commit into from

Conversation

twokul
Copy link
Contributor

@twokul twokul commented Nov 8, 2015

/cc @stefanpenner

@stefanpenner
Copy link
Contributor

awesome, pending the broccoli-funnel windows fix, and we should be good to ship.

+ changes to `tests/index.html` file. All tests are now in a separate file, [diff](https://github.com/twokul/ember-cli-release-notes/commit/bd5ac542c0d6dd8e095553d6528ec40ae4be6b4e).
+ default Ember.js version is now at `1.13.10`
+ default Ember Data version is now at `1.13.14`
+ `ember-cli-ic-ajax` has been dropped in favour of `ember-ajax`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be part of 2.0

@stefanpenner
Copy link
Contributor

1 last thing, ember-ajax switch will be part of 2.0

"ember-cli-shims": "0.0.6",
"ember-cli-test-loader": "0.2.1",
"ember-data": "2.1.0",
"ember-data": "1.13.14",
"ember-load-initializers": "0.1.7",
"ember-qunit": "0.4.13",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump this to 0.4.15? We are are currently using the the wait helper, which was added in 0.4.14.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, submit PR to master

@jcope2013
Copy link
Contributor

under users mention ember-resolver change needed in app.js and test/helpers/resolver.js

import Resolver from 'ember/resolver'; to import Resolver from 'ember-resolver';

aptible/dashboard.aptible.com#423

+ default Ember.js version is now at `1.13.10`
+ default Ember Data version is now at `1.13.14`
+ `ember-cli-ic-ajax` has been dropped in favour of `ember-ajax`
+ Upgrade your project's ember-cli version - [docs](http://www.ember-cli.com/#project-update)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link is broken, correct one: http://www.ember-cli.com/user-guide/#upgrading

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nightire thanks

@twokul
Copy link
Contributor Author

twokul commented Nov 9, 2015

@jcope2013 I thought it would be a part of 2.0.0 release

@jcope2013
Copy link
Contributor

@twokul it looks like it is currently part of 1.13.9, notice the change of ember-resolver being moved from bower to package.json, it could be changed back to use the bower version if that change is wanted for 2.0.0 only

https://github.com/twokul/ember-cli-release-notes/commit/0cef67c2c16cb0d6feac7945fa622013531013e0

@stefanpenner
Copy link
Contributor

it could be changed back to use the bower version if that change is wanted for 2.0.0 only

yes, lets make this a 2.0 change cc @twokul

@twokul
Copy link
Contributor Author

twokul commented Nov 9, 2015

@jcope2013 @stefanpenner looks like I was too hasty to release Ember CLI. thanks for the feedback you guys

@twokul twokul force-pushed the stable-1-13 branch 4 times, most recently from 5da61e8 to db23477 Compare November 9, 2015 06:28
@btecu
Copy link
Contributor

btecu commented Nov 9, 2015

ember-data 1.13.15 fixes two bugs. Maybe we should use that one.

@stefanpenner
Copy link
Contributor

@btecu good call! @twokul can you swap it in?

Also broccoli-merge-trees is now 1.0.0 we should bump that

@twokul
Copy link
Contributor Author

twokul commented Nov 9, 2015

@stefanpenner will do

@twokul twokul force-pushed the stable-1-13 branch 2 times, most recently from 038efce to f905051 Compare November 10, 2015 06:05
@homu
Copy link
Contributor

homu commented Nov 10, 2015

☔ The latest upstream changes (presumably #5052) made this pull request unmergeable. Please resolve the merge conflicts.

@homu
Copy link
Contributor

homu commented Nov 11, 2015

☔ The latest upstream changes (presumably #5054) made this pull request unmergeable. Please resolve the merge conflicts.

@seanpdoyle
Copy link
Contributor

@twokul was this released outside of this PR?

https://github.com/ember-cli/ember-cli/releases/tag/v1.13.9

@stefanpenner
Copy link
Contributor

@seanpdoyle i believe that is part of the release, did we screw something up?

@seanpdoyle
Copy link
Contributor

@stefanpenner I would expect this PR to have been merged and pushed before a release tag was cut, but I'm not involved in this process at all so my expectations are most likely wrong.

@btecu
Copy link
Contributor

btecu commented Nov 11, 2015

@seanpdoyle It was merged in stable-1.13 branch instead of master...

@seanpdoyle
Copy link
Contributor

👌 gotcha sounds great

@stefanpenner
Copy link
Contributor

@seanpdoyle Ya this PR is just tracking progress on this branch, kindy quirky (but its more or less a backport release)

@twokul
Copy link
Contributor Author

twokul commented Nov 11, 2015

@twokul twokul closed this Nov 11, 2015
@seanpdoyle
Copy link
Contributor

Out of the box on a fresh ember init (with 1.13.10), I'm seeing:

ENOENT: no such file or directory, stat  '/Users/seanpdoyle/src/ember-cli-rails-heroku-example/frontend/tmp/concat_with_maps-input_base_path-Ff2y9AN9.tmp/0/bower_components/ember-resolver/dist/modules/ember-resolver.js'

Any ideas?

The example app:

https://github.com/seanpdoyle/ember-cli-rails-heroku-example/tree/master/frontend

EDIT:

Seems to be a duplicate of #5068

What will it take to include a fix in another patch release?

@stefanpenner
Copy link
Contributor

@twokul is fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release plan