-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.13.9
release
#5045
1.13.9
release
#5045
Conversation
awesome, pending the broccoli-funnel windows fix, and we should be good to ship. |
+ changes to `tests/index.html` file. All tests are now in a separate file, [diff](https://github.com/twokul/ember-cli-release-notes/commit/bd5ac542c0d6dd8e095553d6528ec40ae4be6b4e). | ||
+ default Ember.js version is now at `1.13.10` | ||
+ default Ember Data version is now at `1.13.14` | ||
+ `ember-cli-ic-ajax` has been dropped in favour of `ember-ajax` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be part of 2.0
1 last thing, ember-ajax switch will be part of 2.0 |
"ember-cli-shims": "0.0.6", | ||
"ember-cli-test-loader": "0.2.1", | ||
"ember-data": "2.1.0", | ||
"ember-data": "1.13.14", | ||
"ember-load-initializers": "0.1.7", | ||
"ember-qunit": "0.4.13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you bump this to 0.4.15? We are are currently using the the wait
helper, which was added in 0.4.14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, submit PR to master
under users mention ember-resolver change needed in app.js and test/helpers/resolver.js
|
+ default Ember.js version is now at `1.13.10` | ||
+ default Ember Data version is now at `1.13.14` | ||
+ `ember-cli-ic-ajax` has been dropped in favour of `ember-ajax` | ||
+ Upgrade your project's ember-cli version - [docs](http://www.ember-cli.com/#project-update) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link is broken, correct one: http://www.ember-cli.com/user-guide/#upgrading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nightire thanks
@jcope2013 I thought it would be a part of |
@twokul it looks like it is currently part of 1.13.9, notice the change of ember-resolver being moved from bower to package.json, it could be changed back to use the bower version if that change is wanted for 2.0.0 only https://github.com/twokul/ember-cli-release-notes/commit/0cef67c2c16cb0d6feac7945fa622013531013e0 |
yes, lets make this a 2.0 change cc @twokul |
@jcope2013 @stefanpenner looks like I was too hasty to release Ember CLI. thanks for the feedback you guys |
5da61e8
to
db23477
Compare
|
@stefanpenner will do |
038efce
to
f905051
Compare
☔ The latest upstream changes (presumably #5052) made this pull request unmergeable. Please resolve the merge conflicts. |
b508d74
to
1fb64fc
Compare
acdc725
to
631a051
Compare
cd87b5a
to
9822b1d
Compare
☔ The latest upstream changes (presumably #5054) made this pull request unmergeable. Please resolve the merge conflicts. |
a8861bd
to
a32c63c
Compare
7ae8eef
to
7756e93
Compare
7756e93
to
b5180f7
Compare
@twokul was this released outside of this PR? |
@seanpdoyle i believe that is part of the release, did we screw something up? |
@stefanpenner I would expect this PR to have been merged and pushed before a release tag was cut, but I'm not involved in this process at all so my expectations are most likely wrong. |
@seanpdoyle It was merged in |
👌 gotcha sounds great |
@seanpdoyle Ya this PR is just tracking progress on this branch, kindy quirky (but its more or less a backport release) |
Out of the box on a fresh
Any ideas? The example app: https://github.com/seanpdoyle/ember-cli-rails-heroku-example/tree/master/frontend EDIT: Seems to be a duplicate of #5068 What will it take to include a fix in another patch release? |
@twokul is fixing |
1.13.9
1.13.10
1.13.14
fixes release plan #5028
/cc @stefanpenner