Fix test server file serving #5241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outputDir has nothing to do with this, as the files are served from the latest broccoli build directory not `dist`. This is the case, to allow concurrent broccoli builds of different environments. If we served from `dist` we would serve w/e the last build was, regardless if it matched the environment the server is running in
* lstatSync(symlink).isFile() is always false, as isSymoblicLink() == true * statSync(symlink).isFile() is true if the symlink source is a file
stefanpenner
added a commit
that referenced
this pull request
Dec 22, 2015
Fix test server file serving
homu
added a commit
that referenced
this pull request
Dec 22, 2015
Backports #5241 (Fix test server file serving).
homu
added a commit
that referenced
this pull request
Dec 22, 2015
Backports #5241 (Fix test server file serving).
stefanpenner
added a commit
that referenced
this pull request
Dec 22, 2015
Backports #5241 (Fix test server file serving).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.