Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add directory option to addon command #5486

Merged
merged 1 commit into from Feb 19, 2016

Conversation

Serabe
Copy link
Contributor

@Serabe Serabe commented Feb 18, 2016

The addon command is built upon new but there was no option for --directory. This PR just adds that option.

I found no place to add a test for the options.

Adds a direction option to `addon` command.
@Serabe
Copy link
Contributor Author

Serabe commented Feb 18, 2016

Tests ready.

@Serabe
Copy link
Contributor Author

Serabe commented Feb 18, 2016

Tests added.

@kellyselden
Copy link
Member

@homu r+

@homu
Copy link
Contributor

homu commented Feb 19, 2016

📌 Commit cbf924a has been approved by kellyselden

@kellyselden
Copy link
Member

Thank you.

@homu
Copy link
Contributor

homu commented Feb 19, 2016

⚡ Test exempted - status

@homu homu merged commit cbf924a into ember-cli:master Feb 19, 2016
homu added a commit that referenced this pull request Feb 19, 2016
[ENHANCEMENT] Add `directory` option to `addon` command

The `addon` command is built upon `new` but there was no option for `--directory`. This PR just adds that option.

I found no place to add a test for the options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants