Enable X-Forwarded-* headers in http-proxy #5524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasoning: when using e.g. a Rails backend running on a separate port, proxying it using the ember-cli proxy feature, the generated _links_ sometimes tends to be incorrect. They are based on settings in the X-Forwarded-* headers. Hence, xfwd must be enabled. If you like, we can make this a command-line option. /cc @perlun, @jesjos
|
I wonder if we can leave this on by default... Im not familiar enough with this to know forsure. |
stefanpenner
added a commit
that referenced
this pull request
Mar 3, 2016
Enable X-Forwarded-* headers in http-proxy
jrjohnson
added a commit
to jrjohnson/ember-cli
that referenced
this pull request
Mar 9, 2016
This is a breaking change as these headers cause proxying to break when using a symfony backend in development environemnt mode.
|
For reference: #5986 made this configurable. (it's still enabled by default) |
|
For others who may be google searching why their django backends all of sudden started returning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning: when using e.g. a Rails backend running on a separate port, proxying it using the ember-cli proxy feature, the generated links sometimes tends to be incorrect. They are based on settings in the X-Forwarded-* headers. Hence, xfwd must be enabled.
If you like, we can make this a command-line option.
/cc @perlun, @jesjos