Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "coveralls" and "codeclimate" dependencies into TravisCI manifest #5617

Merged
merged 1 commit into from Mar 16, 2016

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Mar 16, 2016

This PR moves the "coveralls" and "codeclimate" dependencies into the TravisCI manifest. They are usually only needed for CI and not on developer machines.

There is no need to install these on developer machines
@stefanpenner
Copy link
Contributor

I believe we may want to run coveralls locally as well.

@Turbo87
Copy link
Member Author

Turbo87 commented Mar 16, 2016

@stefanpenner are you sure? the coverage information is still shown locally when npm run test-all:cover is used because it's provided by istanbul. coveralls only feeds that information into https://coveralls.io/ which I don't think should be done locally.

@stefanpenner
Copy link
Contributor

Oops. You are correct. 🚢

@Turbo87
Copy link
Member Author

Turbo87 commented Mar 16, 2016

@homu r+

@homu
Copy link
Contributor

homu commented Mar 16, 2016

📌 Commit fbd2111 has been approved by Turbo87

homu added a commit that referenced this pull request Mar 16, 2016
Move "coveralls" and "codeclimate" dependencies into TravisCI manifest

This PR moves the "coveralls" and "codeclimate" dependencies into the TravisCI manifest. They are usually only needed for CI and not on developer machines.
@homu
Copy link
Contributor

homu commented Mar 16, 2016

⌛ Testing commit fbd2111 with merge 0a3a12e...

@homu
Copy link
Contributor

homu commented Mar 16, 2016

☀️ Test successful - status

@homu homu merged commit fbd2111 into ember-cli:master Mar 16, 2016
@Turbo87 Turbo87 deleted the coveralls-codeclimate branch March 21, 2016 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants