Remove "ember help <something> --json" output #5801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"ember help --json" contains all the same things and there really is not advantage of "ember help <something> --json" anymore
|
Looks good, but I thought you wanted to keep it deprecated for a while? |
|
I think due to #5626 (comment) that's no longer necessary |
|
LGTM |
|
@homu r+ |
|
📌 Commit 8f4e3cd has been approved by |
homu
added a commit
that referenced
this pull request
Apr 17, 2016
Remove "ember help <something> --json" output This removes the ability to call `ember help <something> --json` in favor of `ember help --json` which contains all the same information already. Resolves #5626
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the ability to call
ember help <something> --jsonin favor ofember help --jsonwhich contains all the same information already.Resolves #5626