Generate JSHint files only if JSHint is used #5895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
|
||
| beforeInstall: function() { | ||
| // make sure to create `lib` directory even if .jshintrc is not created | ||
| fs.mkdirsSync('lib'); |
There was a problem hiding this comment.
should this add a .gitkeep so it gets commited and shared with other project collaborators?
There was a problem hiding this comment.
It should, but it can't because gitkeeps have special handling currently and won't be generated (which is a bug in itself IMHO)
|
@homu r+ |
|
📌 Commit 0850709 has been approved by |
homu
added a commit
that referenced
this pull request
May 21, 2016
Generate JSHint files only if JSHint is used one more step towards deprecating JSHint...
|
💔 Test failed - status |
|
@homu retry |
homu
added a commit
that referenced
this pull request
May 22, 2016
Generate JSHint files only if JSHint is used one more step towards deprecating JSHint...
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one more step towards deprecating JSHint...