remove slow express-server-restart tests #5912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stefanpenner
commented
May 20, 2016
stefanpenner
commented
- We have sufficient unit test coverage.
- if issues are discovered regression tests should remove unit covered.
* We have sufficient unit test coverage. * if issues are discovered regression tests should remove unit covered.
|
Since the test have been disabled for some time already I think we can safely remove it. @homu r+ |
|
📌 Commit f6a9df5 has been approved by |
homu
added a commit
that referenced
this pull request
May 20, 2016
remove slow express-server-restart tests * We have sufficient unit test coverage. * if issues are discovered regression tests should remove unit covered.
yup. |
|
💔 Test failed - status |
|
the breaking tests seem completely unrelated... merging manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.