[BUGFIX release] ease core-object upgrade for addons which lack .project #5972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
ease-core-object-upgrade
branch
from
753b5ec
to
118e3fa
Compare
|
👍 |
| @@ -31,6 +31,17 @@ describe('models/addon.js', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('old core object compat', function() { | |||
| it.only('treeGenerator works without .project', function() { | |||
stefanpenner
force-pushed
the
ease-core-object-upgrade
branch
from
118e3fa
to
5be9842
Compare
|
this will need to be (once green) cherry-picked to all the active branches
Most likely need new releases for:
|
|
Confirmed this fixes the issue in question. I'll be able to cut a new release around noon PST |
|
@homu r- |
|
Blocking for a second: we need to provide an error message or we'll never migrate the community off of broken addons. |
I can add a warning |
|
Color is wrong but if an addon doesn't have project, it likely also doesn't have UI. So I think its ok. |
stefanpenner
force-pushed
the
ease-core-object-upgrade
branch
from
4b97c8a
to
1f13b34
Compare
|
Ah my OCD wont allow that, fixed:
|
stefanpenner
force-pushed
the
ease-core-object-upgrade
branch
from
1f13b34
to
a410a3e
Compare
Some addons may not have been instantiated correctly (for latest CoreObject) This detects a common failure mode. Hopefully this helps us catch and upgrade these addons quickly.
stefanpenner
force-pushed
the
ease-core-object-upgrade
branch
from
a410a3e
to
6cb0713
Compare
|
@homu r+ |
|
📌 Commit 6cb0713 has been approved by |
homu
added a commit
that referenced
this pull request
Jun 11, 2016
…mond [BUGFIX release] ease core-object upgrade for addons which lack .project
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.