Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prints correct phantomjs version #5997

Merged
merged 1 commit into from
Jun 18, 2016
Merged

Prints correct phantomjs version #5997

merged 1 commit into from
Jun 18, 2016

Conversation

twokul
Copy link
Contributor

@twokul twokul commented Jun 18, 2016

resolves #5906

@nathanhammond
Copy link
Contributor

@homu r+

@homu
Copy link
Contributor

homu commented Jun 18, 2016

📌 Commit 17854fd has been approved by nathanhammond

@homu
Copy link
Contributor

homu commented Jun 18, 2016

⌛ Testing commit 17854fd with merge e7c3b7a...

homu added a commit that referenced this pull request Jun 18, 2016
@homu
Copy link
Contributor

homu commented Jun 18, 2016

☀️ Test successful - status

@homu homu merged commit 17854fd into master Jun 18, 2016
@nathanhammond nathanhammond deleted the phantomjs-version branch June 18, 2016 21:59
@Turbo87 Turbo87 added this to the v2.8.0 milestone Jun 19, 2016
@Turbo87
Copy link
Member

Turbo87 commented Aug 2, 2016

@twokul it seems that we missed this in 2.7.0. can you verify? I thought the version output was introduced in 2.8.0 instead.

@twokul
Copy link
Contributor Author

twokul commented Aug 2, 2016

@Turbo87 correct, noticed it last night

@twokul
Copy link
Contributor Author

twokul commented Aug 2, 2016

@Turbo87 not a huge deal though imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phantomjs --version in .travis.yml is wrong version
4 participants