New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't treat strings as regex in insertIntoFile #7475

Merged

Turbo87 merged 1 commit into ember-cli:release from kellyselden:insert-into-file

Dec 1, 2017

Member

kellyselden commented Nov 30, 2017

Closes #7473

kellyselden mentioned this pull request

options.before/after in insertIntoFile only supports valid regex #7473

Closed


          don't treat strings as regex in insertIntoFile

f09f310

kellyselden added the bug label

Member Author

kellyselden commented Nov 30, 2017

CI is gradually going green. Anyone want to give it a once over for merge?

Turbo87 approved these changes

View reviewed changes

Turbo87 merged commit b64ffaa into ember-cli:release

kellyselden deleted the insert-into-file branch

December 1, 2017 17:10

av-guy mentioned this pull request

invalid regular expression: /"predef" on install miragejs/ember-cli-mirage#1234

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment