Passing defaultOptions to testem to prevent the cwd and config_dir set in testem.js from being overridden by ember-cli #7700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
requested changes
Mar 26, 2018
tests/unit/tasks/test-server-test.js
Outdated
| @@ -45,6 +45,46 @@ describe('test server', function() { | |||
| watcher.emit('change'); | |||
| }); | |||
|
|
|||
| it('transforms and sets defaultOptions in testem and invokes testem properly', function(done) { | |||
There was a problem hiding this comment.
i would prefer if we just use promises here, rather then a mix of done and promises. The promise mode for mocha will nicely handle errors for us.
lib/tasks/test-server.js
Outdated
| return new Promise((resolve, reject) => { | ||
| task.testem.startDev(task.testemOptions(options), (exitCode, error) => { | ||
| if (task.testem.setDefaultOptions) { | ||
| task.testem.setDefaultOptions(task.testemOptions(options)); |
lib/tasks/test-server.js
Outdated
| if (task.testem.setDefaultOptions) { | ||
| task.testem.setDefaultOptions(task.testemOptions(options)); | ||
| } else { | ||
| // To make it backward compatibile with older versions of testem (2.0.0 and lower) |
There was a problem hiding this comment.
I don't think we need this branch, as ember-cli will need to bump its minimum testem version to one that supports this feature
stefanpenner
approved these changes
Mar 27, 2018
|
I’m currently on vacation, but I’ll cut a new version once I’m back in 2 days |
|
Fixing the issue in #7728 and closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ember-cli invokes testem it provides defaultOptions for testem to use as a fallback option. But currently, the fallback option from ember-cli is used as progOptions in testem. And since progOptions has higher priority than fileOptions, the cwd being set in the testem.js file of an ember app is being overridden by ember-cli's fallbackOption.
Solution is to add defaultOptions as a sibling to progOptions and fileOptions in testem. And ember-cli can set defaultOptions invoke testem.
Related work in testem is in the below PR.
testem/testem#1219