Modernize install-blueprint-task.js test

[RichardOtvos]

No description provided.

[RichardOtvos]

@Turbo87 Do we want to replace the the .to.eventually.equal type of assertions with an await and to.equal type ones as part of this task?

Like this:

it('resolves "foobar" by looking up the "foobar" blueprint locally', function() {
      let foobarBlueprint = { name: 'foobar blueprint' };
      td.when(task._lookupBlueprint('foobar')).thenResolve(foobarBlueprint);
      return expect(task._resolveBlueprint('foobar')).to.eventually.equal(foobarBlueprint);
});

with something like this

it('resolves "foobar" by looking up the "foobar" blueprint locally', async function() {
      let foobarBlueprint = { name: 'foobar blueprint' };
      td.when(task._lookupBlueprint('foobar')).thenResolve(foobarBlueprint);
      
      const resolvedBlueprint = await task._resolveBlueprint('foobar');
      expect(resolvedBlueprint).to.equal(foobarBlueprint);
});

[Turbo87]

yes, I think something like this makes sense:

it('resolves "foobar" by looking up the "foobar" blueprint locally', async function() {
      let foobarBlueprint = { name: 'foobar blueprint' };
      td.when(task._lookupBlueprint('foobar')).thenResolve(foobarBlueprint);
      expect(await task._resolveBlueprint('foobar')).to.equal(foobarBlueprint);
});

[RichardOtvos]

@Turbo87 Do you see any benefits in changing the way we handle testing promise rejections, from

      // normal function (and what we currently have in the codebase)
      return expect(task.ensureBower()).to.be.rejectedWith('foobar');

to

      //async function
      await expect(task.ensureBower()).to.be.rejectedWith('foobar');

The benefit I see in the second way, is that it would mean you always use async functions when you test Promises (rather than only use them when testing for resolved promises), but I'm not sure if it's worth switching for that alone.

I've experimented with some other ways to test rejections, but everything I could think of was a lot more verbose or invasive than chai-as-promised .rejectedWith assertion.
I'm open to ideas if you can think of anything else. :)

[Turbo87]

@RichardOtvos yep, that second snippet looks 👌 to me! :)

[Turbo87]

👏 nice work, just a few small comments

[RichardOtvos]

This should be ready, let me know if you require any more changes.

[Turbo87]

muchas gracias 👏