Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate test loader changes in ember-cli-qunit@4 #81

Closed
rwjblue opened this issue Mar 27, 2017 · 9 comments
Closed

Investigate test loader changes in ember-cli-qunit@4 #81

rwjblue opened this issue Mar 27, 2017 · 9 comments
Labels

Comments

@rwjblue
Copy link
Member

rwjblue commented Mar 27, 2017

Just a reminder to double check to the changes made in ember-cli/ember-cli-qunit#176 to make sure ember-exam still functions properly.

@trentmwillis
Copy link
Member

So the ember-cli-qunit changes do cause problems here, I'm going to investigate a way to make it backwards and forwards compatible.

@calderas
Copy link

calderas commented May 3, 2017

I think parallelization is no longer working on ember-cli v2.13.x due to this change since it comes with ember-cli-qunit v4.0.x by default.

@trentmwillis
Copy link
Member

Seems likely. I'll try to find some time to look into it soon but would greatly appreciate if someone else could investigate before then.

@calderas
Copy link

I can confirm TestLoader.prototype.loadModules is not being executed when using ember-cli-qunit v4.0.x

That means ember exam runs the whole test suite N times when using --parallel --split=N

I guess this needs to be refactored to support the new behavior on cli-qunit.
https://github.com/trentmwillis/ember-exam/blob/master/vendor/ember-exam/test-loader.js#L55-L59

@trentmwillis
Copy link
Member

Looks like ember-cli-qunit@4.0.0 changed the order of execution of some things, thus test-helper.js runs first and calls start() which runs the TestLoader. This happens before ember-exam can monkeypatch the TestLoader class. I want to update this addon to take a more explicit approach, similar to ember-cli-qunit.

@YoranBrondsema
Copy link
Contributor

I'm encountering the same issue, i.e. the whole suite is executed when splitting. @trentmwillis anything I can do to help getting your PR in master?

@trentmwillis
Copy link
Member

I just released v0.7.0 which should make it possible to work with ember-cli-qunit@4.0.0. Note you'll need to invoke a new loadEmberExam function though.

@YoranBrondsema
Copy link
Contributor

@trentmwillis Awesome, works for me. Thanks so much!

@scottkidder
Copy link

scottkidder commented Jun 2, 2017

Works for me for the most part except for #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants