Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section to the README for deprecations #399

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Add section to the README for deprecations #399

merged 1 commit into from
Nov 26, 2019

Conversation

locks
Copy link
Contributor

@locks locks commented Nov 24, 2019

I put it in the README to make it the easiest to find and because I wanted to get the suggestion down before I forgot, but I am completely open to alternative suggestions :)
I had to do some spelunking because the deprecation mentions FetchAdapter but the documentation names the default export as AdapterFetch to match the module name.

@locks locks requested a review from xg-wang November 24, 2019 23:31
@xg-wang
Copy link
Member

xg-wang commented Nov 26, 2019

LGTM.

re: FetchAdapter / AdapterFetch Ugh this is annoying, I may have followed ember-data's adapter naming and forgot to check the actual name.

@xg-wang xg-wang merged commit 6ae8d6d into master Nov 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the locks-patch-1 branch November 26, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants