Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the type for data property to be less restrictive. #568

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

LuisAverhoff
Copy link

@LuisAverhoff LuisAverhoff commented Oct 6, 2020

Removes the restriction of the data property having to be type of PlainObject where only the properties are strings, objects with strings or an array of objects containing strings. Allow objects will null or undefined properties

@xg-wang
Copy link
Member

xg-wang commented Jan 18, 2021

This looks reasonable, I dug a bit down, the final place the type is used is at

https://github.com/ember-cli/ember-fetch/blob/v8.0.2/addon/utils/serialize-query-params.ts#L56-L67
and the expected type indeed can be as the PR specifies

declare function encodeURIComponent(uriComponent: string | number | boolean): string;

@xg-wang xg-wang merged commit f005511 into ember-cli:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants