Avoid double walking of all modules #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this addon walks all of the modules twice in order to determine the modules that are initializers and instance initializers. We can squash the `map` and `filter` loops into one. This PR addresses that.
| } | ||
| } | ||
|
|
||
| deps.forEach(function(dep) { |
There was a problem hiding this comment.
Why not go even further and remove this forEach? Seems like it's logic could be moved into the if (matches...) { block above. Would also allow getting rid of deps which doesn't seem to be used for anything other than storing a temporary list modules.
There was a problem hiding this comment.
It wouldn't make a much difference except of using a small temp array. The deps array is going to much much smaller than the all modules array. In anycase, I have updated and squashed everything into one loop.
Currently this addon walks all of the modules twice in order to determine the modules that are initializers and instance initializers. We can squash the `map` and `filter` loops into one. This PR addresses that.
|
CI is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this addon walks all of the modules twice in order to determine the modules that are initializers and instance initializers. We can squash the
mapandfilterloops into one.This PR addresses that.
cc: @chadhietala